[trace-debug] Added support for global locations #20821
Merged
+2,009
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
approved these changes
Jan 9, 2025
| if (this.trace.events.length <= this.eventIndex + 1 || | ||
| this.trace.events[this.eventIndex + 1].type !== TraceEventKind.CloseFrame) { | ||
| throw new Error('Expected an CloseFrame event after native OpenFrame event'); | ||
| // process optional effects until reaching CloseFrame for the native function |
Indeed. Global locations are never shown in the UI and lifetimes are only needed for locals that do end up being shown there (so that we can stop showing them after they are no longer live) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it appears, we actually need full support for global values. At least one (and immediate) reason for it is that we need to support reading a value from global location where it has been deposited as a result of a native function returning a value.
A particular example of this is related to dynamic fields where
dynamic_fields::borrow_child_objectreturns a reference to a value that in some cases is NOT stored in a local variable before it is being picked up by a write to a different local.Test plan
A new test has been added and all other existing tests must pass